add k8s runner config loading from envvars #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshrwolf
commented
Jul 25, 2023
joshrwolf
force-pushed
the
k8s-runner-envconfig
branch
from
478d7ed to
0abedca
Compare
mattmoor
previously approved these changes
Jul 25, 2023
joshrwolf
force-pushed
the
k8s-runner-envconfig
branch
2 times, most recently
from
ddb3c11 to
a12a090
Compare
Signed-off-by: Josh Wolf <josh@wolfs.io>
joshrwolf
force-pushed
the
k8s-runner-envconfig
branch
from
a12a090 to
b1d6b76
Compare
mattmoor
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds a 3rd config loading strategy to put us at:
.melange.k8s.yamladds tests to cover